Skip to content

[no-relnote] remove unused param from NewDriverLibraryDiscoverer #1798

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cdesiniotis merged 1 commit into from
May 7, 2026
+2 −7
Merged

[no-relnote] remove unused param from NewDriverLibraryDiscoverer #1798

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 2 additions & 7 deletions pkg/nvcdi/driver-nvml.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,12 +41,7 @@ func (l *nvcdilib) newDriverVersionDiscoverer() (discover.Discover, error) {
return nil, fmt.Errorf("failed to determine driver version (%q): %w", version, err)
}

libcudasoParentDirPath, err := l.driver.GetDriverLibDirectory()
if err != nil {
return nil, fmt.Errorf("failed to get libcuda.so parent path: %w", err)
}

libraries, err := l.NewDriverLibraryDiscoverer(version, libcudasoParentDirPath)
libraries, err := l.NewDriverLibraryDiscoverer(version)
if err != nil {
return nil, fmt.Errorf("failed to create discoverer for driver libraries: %v", err)
}
Expand Down Expand Up @@ -74,7 +69,7 @@ func (l *nvcdilib) newDriverVersionDiscoverer() (discover.Discover, error) {
}

// NewDriverLibraryDiscoverer creates a discoverer for the libraries associated with the specified driver version.
func (l *nvcdilib) NewDriverLibraryDiscoverer(version string, libcudaSoParentDirPath string) (discover.Discover, error) {
func (l *nvcdilib) NewDriverLibraryDiscoverer(version string) (discover.Discover, error) {
versionSuffixLibraryMounts, err := l.getVersionSuffixDriverLibraryMounts(version)
if err != nil {
return nil, err
Expand Down
Loading