-
Notifications
You must be signed in to change notification settings - Fork 44
Megatron-Bridge r0.3.0 enhancement #830
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
juntaowww
wants to merge
30
commits into
NVIDIA:main
Choose a base branch
from
juntaowww:mbridge_r0.3.0
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
30 commits
Select commit
Hold shift + click to select a range
a0d54a4
Make node placement correctly propagate M-Bridge
juntaowww e9b1218
Allow excluding nodes from group of nodes
juntaowww d720616
Also init submodules when install git repos
juntaowww ea4844d
Add options to mount the repo in the container
juntaowww 9f786ff
Fix slurm gpu resource requesting
juntaowww e6c9cb2
Update gb200 M-Bridge r0.3.0 qwen recipe
juntaowww 2acfb29
ruff check & ruff format
juntaowww 45e6153
Fix tests to reflect updates
juntaowww e14fa6f
Update copyright year
juntaowww 54f4fbb
Add back the defensive filter
juntaowww ff2f2fd
Enhance nodes allocation for edge cases
juntaowww f26fe7b
Enhance tests by avoiding default names
juntaowww a159736
Make exclude nodes correctly propagate to M-Bridge
juntaowww 5da0a57
Improve error messages for excluding nodes
juntaowww 2d7b98b
Improve exclude nodes APIs
juntaowww 174dcef
Change additional_slurm_params separator to semi-colon
juntaowww 3480ba8
Make init_submodules optional
juntaowww e12ec45
Update configurations
juntaowww af471d5
Make extra_srun_args correctly propagate to M-Bridge
juntaowww 52cef4c
Allow submission of jobs to resv nodes
juntaowww 62f5cf7
Make the no-mount assertion less brittle
juntaowww f1b027e
Fix and improve the extra_srun_args propagation
juntaowww b6a5dcf
ruff format & copyright year
juntaowww f463df3
Fix init_submodules is silently bypassed on pre-existing clones
juntaowww 6edc15e
Use shlex.split() instead of str.split()
juntaowww 66fbb33
Add missing regression: existing repo + init_submodules=True
juntaowww 59166d6
Export container-runtime env vars before Megatron-Bridge launcher
juntaowww f5681b8
Add supports_gpu_directives check
juntaowww 15081a6
Fix tests
juntaowww 3a1a996
Restructure configurations
juntaowww File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 changes: 1 addition & 1 deletion
2
conf/experimental/megatron_bridge/test_scenario/megatron_bridge_qwen_30b.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
31 changes: 31 additions & 0 deletions
31
conf/experimental/megatron_bridge/test_scenario/megatron_bridge_r0.3.0_qwen_30b.toml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,31 @@ | ||
| # SPDX-FileCopyrightText: NVIDIA CORPORATION & AFFILIATES | ||
| # Copyright (c) 2026 NVIDIA CORPORATION & AFFILIATES. All rights reserved. | ||
| # SPDX-License-Identifier: Apache-2.0 | ||
| # | ||
| # Licensed under the Apache License, Version 2.0 (the "License"); | ||
| # you may not use this file except in compliance with the License. | ||
| # You may obtain a copy of the License at | ||
| # | ||
| # http://www.apache.org/licenses/LICENSE-2.0 | ||
| # | ||
| # Unless required by applicable law or agreed to in writing, software | ||
| # distributed under the License is distributed on an "AS IS" BASIS, | ||
| # WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| # See the License for the specific language governing permissions and | ||
| # limitations under the License. | ||
|
|
||
| name = "megatron_bridge_qwen_30b" | ||
|
|
||
| [[Tests]] | ||
| id = "megatron_bridge_qwen_30b" | ||
| test_name = "megatron_bridge_qwen_30b" | ||
| num_nodes = "2" | ||
|
|
||
| [[Tests.git_repos]] | ||
| url = "https://github.com/NVIDIA-NeMo/Megatron-Bridge.git" | ||
| commit = "r0.3.0" | ||
| mount_as = "/opt/Megatron-Bridge" | ||
| init_submodules = true | ||
|
|
||
| [Tests.extra_env_vars] | ||
| PYTHONPATH = "/opt/Megatron-Bridge/3rdparty/Megatron-LM:${PYTHONPATH}" |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.