Conversation
…filter-api fix: 協賛活動一覧の協賛スタイル絞り込み時のエラー修正
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
| accessToken := params.AccessToken | ||
| isSignIn, err := h.mailAuthUseCase.IsSignIn(c.Request().Context(), *accessToken) | ||
| if err != nil { | ||
| return nil |
There was a problem hiding this comment.
🔴 Error swallowed in GetMailAuthIsSignin — returns nil instead of the error
When h.mailAuthUseCase.IsSignIn() returns an error, the handler returns nil (line 17), which makes Echo send a 200 OK with an empty body to the client. The client receives a success response even though the sign-in check failed. This silently hides authentication errors and can cause incorrect UI behavior (e.g., showing a user as signed-in when the check failed).
| return nil | |
| return err |
Was this helpful? React with 👍 or 👎 to provide feedback.
| if err := serverComponents.Echo.Start(":1323"); err != nil { | ||
| panic(err) | ||
| } | ||
|
|
||
| defer client.CloseDB() | ||
| defer serverComponents.Client.CloseDB() |
There was a problem hiding this comment.
🔴 defer CloseDB() placed after blocking Echo.Start() — DB connection never closed
defer serverComponents.Client.CloseDB() on line 23 is placed after the serverComponents.Echo.Start() call on line 19 which blocks until the server shuts down. If Echo.Start() returns an error, panic(err) is called before the defer is registered, so CloseDB() never executes. Even during graceful shutdown, the defer statement is reached after the blocking call returns, but in the panic case the defer hasn't been registered. The defer should be placed immediately after InitializeServer() returns successfully.
| if err := serverComponents.Echo.Start(":1323"); err != nil { | |
| panic(err) | |
| } | |
| defer client.CloseDB() | |
| defer serverComponents.Client.CloseDB() | |
| defer serverComponents.Client.CloseDB() | |
| if err := serverComponents.Echo.Start(":1323"); err != nil { | |
| panic(err) | |
| } |
Was this helpful? React with 👍 or 👎 to provide feedback.
…-sponsor-activities
- 協賛スタイル未選択時のバリデーションを撤廃\n- 活動ステータスを協賛不可にした際、協賛可否が未着手なら自動で否を設定 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
…b.com/NUTFes/FinanSu into feat/yama/refactor-sponsor-activities
…ities [フロント] 協賛活動一覧ページの改修
…TFes/FinanSu into fix/wakape/unify-format-rules
…tamesu Fix/hikahana/unify format rules tamesu
Fix/wakape/unify format rules
6 participants
対応Issue
resolve #0
概要
画面スクリーンショット等
URLスクリーンショット
テスト項目
備考