CCM-17346: Add Shared Modules#111
Merged
Merged
Conversation
This reverts commit 3c6fccf.
There was a problem hiding this comment.
Pull request overview
Migrates this repository away from in-repo composite actions and bespoke git-hook scripts toward the NHSDigital/nhs-notify-shared-modules shared composite actions and pre-commit hooks, with accompanying documentation/workflow updates.
Changes:
- Switch pre-commit to consume hook implementations from
nhs-notify-shared-modulesand update local scripts accordingly. - Update CI workflows to use shared composite actions and add a PR title format check workflow.
- Update user/developer documentation to reflect the shared-modules-based approach.
Reviewed changes
Copilot reviewed 28 out of 28 changed files in this pull request and generated 28 comments.
Show a summary per file
| File | Description |
|---|---|
| scripts/tests/style.sh | Replaces direct hook script calls with pre-commit invocation for english-usage checks. |
| scripts/config/pre-commit.yaml | Points hook sources at NHSDigital/nhs-notify-shared-modules and passes hook args. |
| scripts/config/check-todos-ignore.conf | Adds ignore configuration for TODO scanning. |
| docs/user-guides/Scan_secrets.md | Updates instructions/links for shared action + pre-commit usage. |
| docs/user-guides/Scan_dependencies.md | Updates action reference to shared action. |
| docs/user-guides/Run_Git_hooks_on_commit.md | Updates narrative to describe pre-commit + shared hooks. |
| docs/user-guides/Perform_static_analysis.md | Updates action reference to shared action. |
| docs/developer-guides/Scripting_Terraform.md | Updates Terraform CI hook/action references to shared modules. |
| .github/workflows/stage-1-commit.yaml | Swaps in shared composite actions for commit-stage checks. |
| .github/workflows/stage-2-test.yaml | Simplifies test-stage workflow and uses shared static analysis action. |
| .github/workflows/cicd-4-pr-title-check.yaml | Adds PR title format validation using shared action. |
| .github/workflows/scheduled-repository-template-sync.yaml | Updates path used to run the template sync script. |
| .github/workflows/manual-combine-dependabot-prs.yaml | Updates generated PR title/body header strings. |
| .github/dependabot.yaml | Adjusts dependabot configuration (prefix/cooldown/ecosystem). |
| .gitattributes | Removes linguist-vendored marking for scripts/githooks/**. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
sidnhs
approved these changes
May 12, 2026
aidenvaines-cgi
approved these changes
May 13, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Drop repo included github composite actions
Update workflows to use shared-modules composite actions
Drop repo included githook scripts
Update precommit-hooks to use tagged hooks from shared-modules repo