CCM-17343: Add routing for supplier config data#136
Open
stevebux wants to merge 2 commits into
Open
Conversation
stevebux
changed the title
stevebux
force-pushed
the
feature/CCM-17343-Route-Supplier-Config
branch
from
d042837 to
94ac39a
Compare
stevebux
force-pushed
the
feature/CCM-17343-Route-Supplier-Config
branch
2 times, most recently
from
55f0113 to
9785cfb
Compare
There was a problem hiding this comment.
Pull request overview
Adds EventBridge routing to forward Supplier Config events from the control-plane event bus to the Supplier API SNS target, including a dedicated DLQ and required IAM role/policy wiring. Also updates the control-plane event bus ingestion policy to allow an additional principal role pattern.
Changes:
- Add a new control-plane EventBridge rule + target to route
uk.nhs.notify.supplier-config*events to the Supplier API SNS topic, with a DLQ. - Add a new SQS DLQ module and queue policy allowing EventBridge to send failed deliveries.
- Expand the control-plane event bus policy’s
aws:PrincipalArnallowlist to include theservice-role/GitHub_Deployrole path.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| infrastructure/terraform/components/events/module_supplier_config_to_supplier_api_events_dlq.tf | Introduces a new DLQ module + policy document for the new Supplier Config → Supplier API routing. |
| infrastructure/terraform/components/events/cloudwatch_event_rule_supplier_config_to_supplier_api.tf | Adds the EventBridge rule/target and the IAM role/policy enabling publish to the Supplier API SNS topic. |
| infrastructure/terraform/components/events/cloudwatch_event_bus_policy_control_plane.tf | Extends the control-plane event bus ingest policy allowlist to include the GitHub deploy role path. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| values = distinct(flatten([ | ||
| formatlist("arn:aws:iam::%s:role/comms-*-api-event-publisher", var.event_publisher_account_ids), | ||
| formatlist("arn:aws:iam::%s:role/nhs-notify-*-eventpub", var.event_publisher_account_ids), | ||
| formatlist("arn:aws:iam::%s:role/service-role/GitHub_Deploy", var.event_publisher_account_ids), |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Context
Type of changes
Checklist
Sensitive Information Declaration
To ensure the utmost confidentiality and protect your and others privacy, we kindly ask you to NOT including PII (Personal Identifiable Information) / PID (Personal Identifiable Data) or any other sensitive data in this PR (Pull Request) and the codebase changes. We will remove any PR that do contain any sensitive information. We really appreciate your cooperation in this matter.