Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions .github/workflows/pull-request.yml
Original file line number Diff line number Diff line change
Expand Up @@ -33,9 +33,11 @@ jobs:

- name: merge into base_branch
if: ${{ github.event_name == 'pull_request' }}
env:
PR_HEAD_REF: ${{ github.head_ref }}
run: |
echo base branch "${{ github.base_ref }}"
echo pr branch "${{ github.head_ref }}"
echo "pr branch $PR_HEAD_REF"
git checkout "${{ github.base_ref }}"
git checkout -b "merging-${{ github.event.number }}"
git merge --ff-only "${{ github.event.pull_request.head.sha }}"
Expand Down Expand Up @@ -85,9 +87,11 @@ jobs:

- name: merge into base_branch
if: ${{ github.event_name == 'pull_request' }}
env:
PR_HEAD_REF: ${{ github.head_ref }}
run: |
echo base branch "${{ github.base_ref }}"
echo pr branch "${{ github.head_ref }}"
echo "pr branch $PR_HEAD_REF"
git checkout "${{ github.base_ref }}"
git checkout -b "merging-${{ github.event.number }}"
git merge --ff-only "${{ github.event.pull_request.head.sha }}"
Expand Down Expand Up @@ -203,9 +207,11 @@ jobs:

- name: merge into base_branch
if: ${{ github.event_name == 'pull_request' }}
env:
PR_HEAD_REF: ${{ github.head_ref }}
run: |
echo base branch "${{ github.base_ref }}"
echo pr branch "${{ github.head_ref }}"
echo "pr branch $PR_HEAD_REF"
git checkout "${{ github.base_ref }}"
git checkout -b "merging-${{ github.event.number }}"
git merge --ff-only "${{ github.event.pull_request.head.sha }}"
Expand Down Expand Up @@ -288,9 +294,11 @@ jobs:

- name: merge into base_branch
if: ${{ github.event_name == 'pull_request' }}
env:
PR_HEAD_REF: ${{ github.head_ref }}
run: |
echo base branch "${{ github.base_ref }}"
echo pr branch "${{ github.head_ref }}"
echo "pr branch $PR_HEAD_REF"
git checkout "${{ github.base_ref }}"
git checkout -b "merging-${{ github.event.number }}"
git merge --ff-only "${{ github.event.pull_request.head.sha }}"
Expand Down
60 changes: 11 additions & 49 deletions poetry.lock

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 3 additions & 3 deletions tests/mesh_endpoint_connectivity_tests.py
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,7 @@
import pytest
from requests.exceptions import ConnectionError as RequestsConnectionError
from requests.exceptions import HTTPError, SSLError
from urllib3.exceptions import ProxyError

import mesh_client
from mesh_client import DEPRECATED_HSCN_INT_ENDPOINT, Endpoint, MeshClient
Expand All @@ -32,7 +33,6 @@ def _host_resolves(endpoint: Endpoint):

CONNECTION_ABORTED_ERROR = "Connection aborted."
REMOTE_END_CLOSED_CONNECTION = "Remote end closed connection without response"
UNABLE_TO_CONNECT_TO_PROXY = "Unable to connect to proxy"
SSL_CERTIFICATE_ERROR = "SSL certificate error"
LOCAL_HTTPS_PROXY_URL = "http://localhost:8019"

Expand Down Expand Up @@ -295,7 +295,7 @@ def test_internet_endpoints_via_explicit_proxy(name: str, endpoint: Endpoint):
if err.type == SSLError:
assert isinstance(err.value.args[0].reason.args[0], SSLCertVerificationError)
else:
assert err.value.args[0].reason.args[0] == UNABLE_TO_CONNECT_TO_PROXY
assert isinstance(err.value.args[0].reason, ProxyError)
assert str(err.value.args[0].reason.args[1]) == REMOTE_END_CLOSED_CONNECTION


Expand All @@ -311,5 +311,5 @@ def test_internet_endpoints_via_ambient_proxy(name: str, endpoint: Endpoint):
if err.type == SSLError:
assert isinstance(err.value.args[0].reason.args[0], SSLCertVerificationError)
else:
assert err.value.args[0].reason.args[0] == UNABLE_TO_CONNECT_TO_PROXY
assert isinstance(err.value.args[0].reason, ProxyError)
assert str(err.value.args[0].reason.args[1]) == REMOTE_END_CLOSED_CONNECTION
Loading