Skip to content

Feature/ndit 707 add row index #57

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
stevenhsd wants to merge 4 commits into
base: main
Choose a base branch
from

style: sort formating, linting and static typing

a0ec92d
Select commit
Loading
Failed to load commit list.
Open

Feature/ndit 707 add row index #57

style: sort formating, linting and static typing
a0ec92d
Select commit
Loading
Failed to load commit list.
SonarQubeCloud / SonarCloud Code Analysis succeeded Mar 6, 2026 in 35s

Quality Gate passed

Issues
7 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

Annotations

Check failure on line 292 in src/dve/core_engine/message.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Refactor this function to reduce its Cognitive Complexity from 16 to the 15 allowed. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZzEIDEK2vaqiWb_TC_y&open=AZzEIDEK2vaqiWb_TC_y&pullRequest=57

Check warning on line 114 in src/dve/core_engine/backends/implementations/spark/contract.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the opposite operator ("not in") instead. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZzEIDBh2vaqiWb_TC_u&open=AZzEIDBh2vaqiWb_TC_u&pullRequest=57

Check warning on line 432 in src/dve/core_engine/backends/implementations/spark/spark_helpers.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the opposite operator ("not in") instead. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZzEIDB42vaqiWb_TC_v&open=AZzEIDB42vaqiWb_TC_v&pullRequest=57

Check warning on line 119 in src/dve/core_engine/message.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Rename this field "RecordIndex" to match the regular expression ^[_a-z][_a-z0-9]*$. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZzEIDEK2vaqiWb_TC_x&open=AZzEIDEK2vaqiWb_TC_x&pullRequest=57

Check warning on line 178 in src/dve/core_engine/backends/implementations/duckdb/contract.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the opposite operator ("not in") instead. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZzEIDBR2vaqiWb_TC_t&open=AZzEIDBR2vaqiWb_TC_t&pullRequest=57

Check warning on line 158 in src/dve/core_engine/backends/implementations/duckdb/readers/csv.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Remove the unused local variable "df". 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZzEIC-V2vaqiWb_TC_s&open=AZzEIC-V2vaqiWb_TC_s&pullRequest=57

Check warning on line 190 in src/dve/core_engine/backends/utilities.py

See this annotation in the file changed.

@sonarqubecloud sonarqubecloud / SonarCloud Code Analysis

Use the opposite operator ("not in") instead. 

See more on https://sonarcloud.io/project/issues?id=NHSDigital_data-validation-engine&issues=AZzEIDD42vaqiWb_TC_w&open=AZzEIDD42vaqiWb_TC_w&pullRequest=57
View more details on SonarQubeCloud