Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
Updates the CSM API String Arguments Support project for the 2026 Q1 release by adding/refreshing LabVIEW library items, updating packaging metadata, and adjusting CI workflows and documentation.
Changes:
- Added/registered new VIs in LabVIEW class/library files (e.g., numeric testcase and float-string utility).
- Updated VIPM package metadata/version and refreshed library icon metadata.
- Simplified README wording and adjusted GitHub Actions workflows to no longer install an external dependency.
Reviewed changes
Copilot reviewed 6 out of 50 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| testcases/testcase-Supported-Datatype/testcase-Supported-Datatype.lvclass | Adds a new numeric testcase VI to the class project item list. |
| addons/API-String-Arugments-Support/API String Arguments Support.lvlib | Updates library icon metadata and registers a new utility VI. |
| README.md | Updates documentation text and template state list; removes the license badge. |
| CSM API String Arguments Support.vipb | Bumps package version and updates release notes metadata. |
| .github/workflows/Check_Broken_VIs.yml | Comments out dependency installation step and adds explanatory comments. |
| .github/workflows/Build_VIPM_Library.yml | Comments out dependency installation step and adds explanatory comments. |
Comments suppressed due to low confidence (2)
testcases/testcase-Supported-Datatype/testcase-Supported-Datatype.lvclass:1
- The newly added VI name uses different casing ('Numeric') compared to the adjacent 'test - float.vi'. For consistency (and to avoid awkward sorting/grouping in LabVIEW project trees), align naming/casing across these test VIs (e.g., all lower-case or a consistent title-case convention).
addons/API-String-Arugments-Support/API String Arguments Support.lvlib:1 - The NI_IconEditor property value now includes an extra newline (line 9) before the closing tag. For LabVIEW XML metadata, embedded newlines in these serialized binary-as-text fields can change the stored value and may cause the icon editor metadata to be considered corrupted or produce noisy diffs. Recommend removing the blank line so the string is a continuous value (or re-save the library in LabVIEW to ensure the property is serialized correctly).
<?xml version='1.0' encoding='UTF-8'?>
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
5
to
7
| [](https://www.vipm.io/package/nevstop_lib_csm_api_string_arguments_support/) | ||
| [](https://www.vipm.io/package/nevstop_lib_csm_api_string_arguments_support/) | ||
| [](https://opensource.org/licenses/Apache-2.0) | ||
| [](https://github.com/NEVSTOP-LAB/CSM-API-String-Arguments-Support/releases) |
There was a problem hiding this comment.
The License badge/link was removed. If the project is still Apache-2.0 (or any other license), keeping a visible license indicator in the README helps users quickly confirm usage terms. Consider restoring the badge/link or adding a clear 'License' section that matches the repository license file.
Contributor
Author
There was a problem hiding this comment.
@copilot apply changes based on this feedback
Contributor
There was a problem hiding this comment.
Restored the Apache 2.0 license badge in commit 8db4683. The badge now appears between the Stars and GitHub Downloads badges in README.md.
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Agent-Logs-Url: https://github.com/NEVSTOP-LAB/CSM-API-String-Arguments-Support/sessions/cb5f6097-7468-4814-a2e7-4dfe6ee3a1af Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com>
added 2 commits
March 28, 2026 20:21
Agent-Logs-Url: https://github.com/NEVSTOP-LAB/CSM-API-String-Arguments-Support/sessions/d8b32264-5d85-43ac-9905-1840f79a083a Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com>
Contributor
Author
|
@copilot review readme (en/ch)，让两边同步，并且更加的地道、通顺、简洁且容易阅读。 |
Agent-Logs-Url: https://github.com/NEVSTOP-LAB/CSM-API-String-Arguments-Support/sessions/56602093-c286-43b4-9e44-18e8e656f41e Co-authored-by: nevstop <8196752+nevstop@users.noreply.github.com>
Contributor
Done in commit Synchronized (content now matches in both):
Improved for clarity:
|
github-project-automation
bot
moved this from Linked to PR
to Done
in Communicable State Machine(CSM)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.