Conversation
…is out of the aspen repo
…the installbuilder tool
…ion from the general xml file and don't pass it as a target
…from the eol_scons namespace
…ting it, remove obsolete launch_app script
…qt directly instead of as an action, because it doesn't generate a target
garyjg
reviewed
Mar 27, 2026
…ate bundle structure, macdeployqt, fix paths, codesign)
…oy methods together.
… the working directory changes, so update paths to source and target to be relative to that.
garyjg
reviewed
Apr 9, 2026
garyjg
reviewed
Apr 9, 2026
the installmode module handles a command-line argument which can be set to mock or all. the installbuilder and osxapp tools have been instrumented to mock installer build steps, so scons builder nodes for multiple platforms can be debugged from one platform, even when installer utilities are missing. prefer inline string interpolation to concatenation, for readability. prefer SCons Dir and File path operations to converting back and forth to str and using os.path. add WindowsDependencies.xml as a clean target of the installer builder. replace intermediate builders RunInstallBuilder, CreateOsxCmdlineApp, and CreateOsxQtApp with Command builders, since the custom action function can be passed to a Command builder same as the custom builders. call functions like Execute, Dir, and File as Environment methods, to make sure they are executed with the correct context and so they do not need to be imported. use a context when writing plistinfo file so it will be closed
Member
|
I finally reached a stopping point with debugging installer builds on multiple platforms from Linux, and I tried to simplify the code along the way, but of course my testing is limited. If you notice a problem, let me know and I'll fix it. I don't want to cost you extra time debugging something I broke. |
…egrated into scons tools.
Contributor
Author
|
@janineA I've made a bunch of updates to the installbuilder and osxapp tools to bring them up to date with what the current process is. I wanted to ping you here so you have a chance to update aeros and ric to use the new options. |
Contributor
|
@isabels Thank you. (-: |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Working on converting the scripts for fixing dependencies in mac and windows installers to real scons tools, mostly to be able to more easily share functionality between deploying mac apps and mac commandline executables.
@garyjg I think I'm done with the installbuilder tool part of this, if you have any feedback while I work on the mac deploy part of this.