Skip to content

NASA-PDS/registry-api#745: skip failing integration tests#500

Merged
jordanpadams merged 2 commits intodevelopfrom
api-745
Apr 1, 2026
Merged

NASA-PDS/registry-api#745: skip failing integration tests#500
jordanpadams merged 2 commits intodevelopfrom
api-745

Conversation

@al-niessner
Copy link
Copy Markdown
Contributor

@al-niessner al-niessner commented Mar 30, 2026

🗒️ Summary

Some minor cleanup of skips. Local testing requires more skips when using same docker images - maybe. This set fixes local which is a superset of registry-api superset.

🤖 AI Assistance Disclosure

  • No AI assistance used
  • AI used for light assistance (e.g., suggestions, refactoring, documentation help, minor edits)
  • AI used for moderate content generation (AI generated some code or logic, but the developer authored or heavily revised the majority)
  • AI generated substantial portions of this code

Estimated % of code influenced by AI: ___ %

⚙️ Test Data and/or Report

NASA-PDS/registry-api should pass its tests.

♻️ Related Issues

More clarity for NASA-PDS/registry-api#745

🤓 Reviewer Checklist

Reviewers: Please verify the following before approving this pull request.

Documentation and PR Content

  • Documentation: README, Wiki, or inline documentation (Sphinx, Javadoc, Docstrings) have been updated to reflect these changes.
  • Issue Traceability: The PR is linked to a valid GitHub Issue
  • PR Title: The PR title is "user-friendly" clearly identifying what is being fixed or the new feature being added, that if you saw it in the Release Notes for a tool, you would be able to get the gist of what was done.

Security & Quality

  • SonarCloud: Confirmed no new High or Critical security findings.
  • Secrets Detection: Verified that the Secrets Detection scan passed and no sensitive information (keys, tokens, PII) is exposed.
  • Code Quality: Code follows organization style guidelines and best practices for the specific language (e.g., PEP 8, Google Java Style).

Testing & Validation

  • Test Accuracy: Verified that test data is accurate, representative of real-world PDS4 scenarios, and sufficient for the logic being tested.
  • Coverage: Automated tests cover new logic and edge cases.
  • Local Verification: (If applicable) Successfully built and ran the changes in a local or staging environment.

Maintenance

  • Backward Compatibility: Confirmed that these changes do not break existing downstream dependencies or API contracts (or that breaking changes are clearly documented).

@al-niessner al-niessner self-assigned this Mar 30, 2026
@al-niessner al-niessner requested a review from a team as a code owner March 30, 2026 16:51
@al-niessner
Copy link
Copy Markdown
Contributor Author

@jordanpadams @tloubrieu-jpl

These are a reduced set of skips and fix a hard number that might be number of lidvids in db.

@jordanpadams jordanpadams changed the title Api 745 registry-api#745: skip failing integration tests Apr 1, 2026
@jordanpadams jordanpadams merged commit 4eab014 into develop Apr 1, 2026
1 check passed
@jordanpadams jordanpadams deleted the api-745 branch April 1, 2026 21:52
@jordanpadams jordanpadams changed the title registry-api#745: skip failing integration tests NASA-PDS/registry-api#745: skip failing integration tests Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants