fix: use per-CF RocksDB options in drop-column-families dbtool command#3165
Closed
mlegner wants to merge 1 commit intozhewu/db-tool-drop-cffrom
Closed
fix: use per-CF RocksDB options in drop-column-families dbtool command#3165mlegner wants to merge 1 commit intozhewu/db-tool-drop-cffrom
mlegner wants to merge 1 commit intozhewu/db-tool-drop-cffrom
Conversation
The `DropStorageColumnFamiliesFromConfig` command was opening the DB with identical global options for every column family. CFs with custom merge operators (aggregate_blob_info, per_object_blob_info, event_cursor, etc.) need those operators registered to replay WAL entries on open. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
Contributor
Author
|
This is just for temporary use, we'd need to make this a bit more robust as a permanent solution. |
Contributor
|
This PR is stale because it has been open 14 days with no activity. It will be closed in 7 days unless you remove the |
Collaborator
|
I think this is no longer needed after the node successfully started recovery. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
DropStorageColumnFamiliesFromConfigcommand was opening the DB with identical global options for every column family. CFs with custom merge operators (aggregate_blob_info, per_object_blob_info, event_cursor, etc.) need those operators registered to replay WAL entries on open.