refactor: extract parse_size and format_size to walrus-utils#3093
Open
refactor: extract parse_size and format_size to walrus-utils#3093
Conversation
Add phase-level criterion benchmarks (encoding_phases) that measure secondary encoding, primary encoding, hashing, and metadata construction independently at production parameters (n_shards=1000). Add a standalone profiling binary (profile_encoding) designed for use with samply/flamegraph without criterion overhead. Make leaf_hash public to support external benchmarking of hashing costs.
Add heap peak tracking via peakmem-alloc and RSS peak via libc::getrusage() to the profiling binary. Each iteration now reports peak_heap, peak_rss, and heap expansion ratio. Multi-iteration runs report max_peak_heap in the summary.
Add --concurrent-blobs N flag that encodes N blobs simultaneously using std::thread::scope, simulating multi-blob uploads. Reports per-blob latency, total wall time, and peak memory with per-blob expansion ratio for direct comparison with single-blob runs.
Replace rayon's into_par_iter() with bounded concurrency using OS threads for the outer blob encoding loop. This prevents peak memory from scaling linearly with the number of concurrent blobs, since each encoding already saturates the rayon thread pool internally. Uses std::thread::scope with batched OS threads when concurrency > 1, avoiding rayon pool deadlocks. Adds max_concurrent_blob_encodings config field (defaults to 1 for sequential encoding).
Move human-readable size parsing and formatting utilities from profile_encoding example into walrus_utils::size module for reuse across benchmarks and examples.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.