fix: include blob attribute headers on range responses#3084
Merged
Conversation
Contributor
|
Warning: This PR modifies the Walrus CLI. Please consider the following:
|
wbbradley
force-pushed
the
wbbradley/blob-attributes
branch
from
178e1ae to
f55a04d
Compare
The object-ID endpoint only added blob attribute headers (Content-Type, custom headers) when the response status was exactly 200 OK. Range requests return 206 Partial Content, so attributes were silently dropped. Use is_success() to cover all 2xx statuses while still skipping errors. Add a regression test that verifies attribute headers are present on 206 responses from get_blob_by_object_id with a Range request header.
wbbradley
force-pushed
the
wbbradley/blob-attributes
branch
from
f55a04d to
09301c3
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
In
get_blob_by_object_id, blob attribute headers (Content-Type, custom headers, etc.) were only added when the response status was exactly200 OK. Range requests return206 Partial Content, so all attribute headers were silently dropped. Changed the check from ==StatusCode::OKto .is_success() to cover all 2xx statuses.Test plan
Release notes