Add FE Macro control of null HBs in ROC Setup#301
Merged
Conversation
Contributor
There was a problem hiding this comment.
Pull request overview
This PR extends the DTC front-end “ROC Setup” macro so operators can toggle the DTC-wide null-heartbeat blocking and non-null event resequencing bits during ROC setup. It fits into the FE control surface for configuring ROC emulation and related DTC behavior.
Changes:
- Added two new
ROC SetupFE macro inputs for blocking null heartbeats and resequencing non-null events. - Extended the
DTCFrontEndInterface::SetupROCsC++ overload to accept those two new boolean controls. - Ignored generated
UserWebGUI/WebGUI_*directories in.gitignore.
Reviewed changes
Copilot reviewed 2 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
otsdaq-mu2e/FEInterfaces/DTCFrontEndInterfaceImpl.cc |
Adds the new FE macro arguments and applies the new DTC-wide settings inside SetupROCs. |
otsdaq-mu2e/FEInterfaces/DTCFrontEndInterface.h |
Updates the SetupROCs declaration with two new optional boolean parameters. |
.gitignore |
Ignores generated UserWebGUI/WebGUI_* paths. |
corrodis
approved these changes
May 7, 2026
Collaborator
corrodis
left a comment
corrodis
left a comment
There was a problem hiding this comment.
I have not yet tested this, but it looks good. Looks pretty safe to merge in to me. Thanks a lot for adding these features!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.