Jcampos/new db schema#234
Conversation
…hat the issue might be
Testing NewDBSchema
…er with otsdaq/2856e170d0213c24348878cd4b36d4eabf43fde2
New New schema (test_sc)
…ampos/NewDBSchema
|
@copilot fix whitespace issues identified in Git Whitespace Check Workflow |
|
@rrivera747 I've opened a new pull request, #239, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Fix whitespace issue in DBRunInfo.h
There was a problem hiding this comment.
Pull request overview
This PR implements a major database schema refactoring for the otsdaq-mu2e project, migrating from the old run_condition/run_configuration schema to a new config/run schema design. The changes are part of a broader effort spanning multiple repositories (otsdaq-utilities #225 and otsdaq #290).
Changes:
- Updated database table names and schema (run_condition → config, run_configuration → run, etc.)
- Refactored DBRunInfo plugin to work with the new database structure
- Added helper functions for database operations and error reporting
- Modified DTCInterfaceTable method signatures for consistency with base class
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 27 comments.
Show a summary per file
| File | Description |
|---|---|
| otsdaq-mu2e/TablePlugins/DTCInterfaceTable.h | Updated method signature for getStructureAsJSON (renamed from getStructureStatusAsJSON) with const parameter |
| otsdaq-mu2e/TablePlugins/DTCInterfaceTable_table.cc | Implementation update matching header file changes |
| otsdaq-mu2e/RunInfoPlugins/DBRunInfo.h | Major API changes including new helper functions, updated documentation, and transition type structure |
| otsdaq-mu2e/RunInfoPlugins/DBRunInfo_runInfo.cc | Complete rewrite of database interaction logic for new schema, including insertRunCondition, claimNextRunNumber, updateRunInfo, and query methods |
| .gitignore | Added UserWebGUI/ServiceData to ignore list |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
|
@rrivera747 I've opened a new pull request, #240, to work on those changes. Once the pull request is ready, I'll request review from you. |
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Co-authored-by: rrivera747 <107584474+rrivera747@users.noreply.github.com>
Fix comment style inconsistency in DBRunInfo_runInfo.cc documentation
…mu2e into jcampos/NewDBSchema
|
@rrivera747 I've opened a new pull request, #241, to work on those changes. Once the pull request is ready, I'll request review from you. |
rrivera747
left a comment
rrivera747
left a comment
There was a problem hiding this comment.
Now is compatible with latest virtual function definitions of the Run Info plugin.
Part of art-daq/otsdaq-utilities#225 and art-daq/otsdaq#290