Skip to content

build: Enforce complete translations in CI checks #140

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Moustachauve merged 1 commit into from
Mar 23, 2026
Merged

build: Enforce complete translations in CI checks #140

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions app/build.gradle.kts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -75,6 +75,9 @@ android {
enableAggregatingTask = true
}
namespace = "ca.cgagnier.wlednativeandroid"
lint {
fatal += "MissingTranslation"
}
Comment on lines +78 to +80
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot Mar 23, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

This change will make the build fail immediately on your main branch because there are existing missing translations. For example, app/src/main/res/values/strings.xml contains a TODO for widget texts that are likely not translated yet.

To enforce this rule only for new changes, you should use a lint baseline. This will ignore existing issues and only report new ones. The project already uses this approach for detekt.

You can add the baseline to your lint configuration. After that, run ./gradlew :app:lint to generate the lint-baseline.xml file and commit it to your repository.

    lint {
        fatal += "MissingTranslation"
        baseline = file("lint-baseline.xml")
    }

}

ksp {
Expand Down
Loading