Fix ResourceApplyAdam resource variable update and session close crash#78
Merged
tngchien merged 23 commits intoMooreThreads:mainfrom Mar 17, 2026
Merged
Fix ResourceApplyAdam resource variable update and session close crash#78tngchien merged 23 commits intoMooreThreads:mainfrom
tngchien merged 23 commits intoMooreThreads:mainfrom
Conversation
This reverts commit 4fa738f.
welo516
pushed a commit
to welo516/tensorflow_musa_extension
that referenced
this pull request
Mar 17, 2026
…sh (MooreThreads#78) feat: fused_gelu v1 (MooreThreads#72) * feat:fused_gelu v1 feat: optimize addn (MooreThreads#73) feat: optimize addn --------- Co-authored-by: albert <albert@mthreads.com> Co-authored-by: ronnie <ronnie@mt.com> test finally add daily test add daily test2 add daily test3 add daily test4 add daily test4 add daily test5 add daily test5 add daily test5 add daily test5 add daily test5 add daily test5 add daily test5 add daily test5 add daily test5 add daily test5
welo516
pushed a commit
to welo516/tensorflow_musa_extension
that referenced
this pull request
Mar 17, 2026
…sh (MooreThreads#78) feat: fused_gelu v1 (MooreThreads#72) * feat:fused_gelu v1 feat: optimize addn (MooreThreads#73) feat: optimize addn --------- Co-authored-by: albert <albert@mthreads.com> Co-authored-by: ronnie <ronnie@mt.com> test finally add daily test add daily test2 add daily test3 add daily test4 add daily test4 add daily test5 add daily test5 add daily test5 add daily test5 add daily test5 add daily test5 add daily test5 add daily test5 add daily test5 add daily test5
EternityTang
pushed a commit
to EternityTang/tensorflow_musa_extension
that referenced
this pull request
Apr 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
这个 PR 修复了 ResourceApplyAdam 在 graph mode 下的资源变量更新问题，以及 Session.close() 阶段的崩溃问题。
修复后：
MUSA 侧 ResourceApplyAdam 的计算结果与 CPU 对齐
apply_resource_op_test.py 可以稳定通过
MUSA 资源变量在 session 退出时不再触发 refcount.h:90 崩溃