Optimal matrix clean#1050
Merged
helloyongyang merged 2 commits intoModelTC:mainfrom May 6, 2026
Merged
Conversation
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request simplifies the Matrix-Game-3 implementation by removing the WanMtxg3OfficialBaseModel and its associated utility functions, consolidating the inference path to use the WanMtxg3Model with the LightX2V stack. Additionally, it introduces a dummy_model flag in the VAE configuration and loading logic to allow for model initialization without loading full checkpoints. Feedback was provided regarding a vague placeholder comment in matrix_game3_model.py that should be clarified or removed.
helloyongyang
approved these changes
May 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In the previous version, the code is divided into base and distilled. And In this version, we integrate the base into the distilled.