Skip to content

JMEOS v1.3 #8

Open
SachaDelsaux wants to merge 1 commit intoMobilityDB:mainfrom
SachaDelsaux:JMEOS_v1.3
Open

JMEOS v1.3 #8
SachaDelsaux wants to merge 1 commit intoMobilityDB:mainfrom
SachaDelsaux:JMEOS_v1.3

Conversation

@SachaDelsaux
Copy link
Copy Markdown

Summary

This PR upgrades the JMEOS Java bindings to work with MEOS 1.3.
The upgrade compiles successfully

Changes

  • Updated bindings to match the MEOS 1.3 C API.
  • Adjusted FunctionsGenerator and functions.java to reflect API changes.
  • Updated related tests (TGeomPointTest, tstzspanTest, etc.) to ensure compatibility.

Notes

  • This PR is opened as a draft to allow discussion and incremental review.
  • Some tests may still need adaptation to validate against MEOS 1.3.
  • A large test file (scale10.csv, ~50 MB) is currently tracked in Git — this may need to be moved to Git LFS or excluded.

To Do

  • Finalize documentation updates once the bindings are stable.

Status: compiles but pending further review and feedback.

@estebanzimanyi
Copy link
Copy Markdown
Member

Subsumed by PR#9

@estebanzimanyi
Copy link
Copy Markdown
Member

Cross-linking from downstream: tracking the corresponding MobilitySpark bump in MobilityDB/MobilitySpark#1 (companion in-tree planning doc in MobilitySpark#2).

The audit there confirms low downstream-API risk on the MobilitySpark side — that codebase uses only meos_initialize and meos_finalize from JMEOS, both preserved in this PR's functions.java (lines 4430 and 4435).

While this PR is being reviewed, two cleanup items already flagged in the PR body itself but worth surfacing for completeness — both are easy and would let the PR ship cleaner:

  1. hs_err_pid17967.log — this is a JVM crash dump that was committed by accident. Adding it under .gitignore and removing the file from the diff would clean up ~4450 added lines that aren't part of the actual JMEOS work.
  2. scale10.csv (~50 MB) — your PR body already notes this should move to Git LFS or be excluded from the repo. Worth resolving before merge so the repo doesn't permanently carry a 50 MB blob in its history.

Beyond those: a separate but related strategic question is whether JMEOS should publish to Maven Central as part of (or after) this 1.3 release — today, downstream consumers like MobilitySpark vendor the JAR in libs/ and carry a decorative pom.xml dependency block that doesn't resolve. Worth a separate conversation but mentioning here since the 1.3 release is the natural inflection point.

cc @estebanzimanyi @mschoema @JashanReel for visibility on the MobilitySpark-side coordination.

@estebanzimanyi
Copy link
Copy Markdown
Member

Additional downstream context: a MobilitySpark parity RFC has been filed at MobilitySpark#3 that depends on this PR merging (so the parity work is built against stable MEOS 1.3 bindings, not the soon-to-be-stale 1.0 bindings). Phase 1 of that RFC begins when this PR lands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants