Skip to content

Avoid writing files in rules_xcodeproj_generated if content hasn’t changed #3313

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brentleyjones merged 2 commits into from
May 14, 2026
Merged

Avoid writing files in rules_xcodeproj_generated if content hasn’t changed #3313

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0d4c0c8
Avoid writing files in `rules_xcodeproj_generated` if content hasn’t …
brentleyjones May 11, 2026
8a13a59
Fix
brentleyjones May 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
35 changes: 29 additions & 6 deletions xcodeproj/internal/templates/runner.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -120,16 +120,34 @@ readonly output_base="${execution_root%/*/*}"
# Set bazel env
%collect_bazel_env%

cleanup() {
rm -f "${defs_bzl_tmp:-}"
if [[ -n "${installer_inputs_dir:-}" ]]; then
rm -r "$installer_inputs_dir"
fi
}
trap cleanup EXIT

# Avoid touching files in `@rules_xcodeproj_generated` unless their contents
# actually changed. Rewriting them on every invocation invalidates the
# generated package and forces Bazel to redo package analysis on warm runs.
# `BUILD` can be compared directly because it is copied verbatim.
# `defs.bzl` is derived content, so compare its final contents before copying.
# Create files for the generator target
readonly generator_package_directory="$output_base/rules_xcodeproj.noindex/%generator_package_name%"

mkdir -p "$generator_package_directory"
cp "$generator_build_file" "$generator_package_directory/BUILD"
chmod u+w "$generator_package_directory/BUILD"
cp "$generator_defs_bzl" "$generator_package_directory/defs.bzl"
chmod u+w "$generator_package_directory/defs.bzl"
if [[ ! -f "$generator_package_directory/BUILD" ]] || \
! cmp -s "$generator_build_file" "$generator_package_directory/BUILD"
then
cp "$generator_build_file" "$generator_package_directory/BUILD"
chmod u+w "$generator_package_directory/BUILD"
fi

cat <<EOF >> "$generator_package_directory/defs.bzl"
defs_bzl_tmp="$(mktemp)"
cp "$generator_defs_bzl" "$defs_bzl_tmp"

cat <<EOF >> "$defs_bzl_tmp"

# Constants

Expand All @@ -138,9 +156,14 @@ BAZEL_PATH = "$bazel_path"
WORKSPACE_DIRECTORY = "$BUILD_WORKSPACE_DIRECTORY"
EOF

if [[ ! -f "$generator_package_directory/defs.bzl" ]] || ! cmp -s "$defs_bzl_tmp" "$generator_package_directory/defs.bzl"
then
cp "$defs_bzl_tmp" "$generator_package_directory/defs.bzl"
chmod u+w "$generator_package_directory/defs.bzl"
fi

installer_inputs_dir=$(mktemp -d)
readonly installer_inputs_dir
trap 'rm -r "$installer_inputs_dir"' EXIT

bazelrcs=(
--noworkspace_rc
Expand Down
Loading