Skip to content

Stop using prebuilt rsync in installer when not on macOS #3312

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
brentleyjones merged 1 commit into from
May 12, 2026
Merged

Stop using prebuilt rsync in installer when not on macOS #3312

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 12 additions & 7 deletions xcodeproj/internal/templates/installer.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -90,19 +90,24 @@ readonly dest_xcschemes="$dest/xcshareddata/xcschemes"

mkdir -p "$dest_xcschemes"

"$src_rsync" \
--archive \
--perms \
--chmod=u+w,F-x \
--delete \
"$src_xcschemes" "$dest_xcschemes/"

if [[ $(uname) == "Darwin" ]]; then
is_macos=1
readonly rsync="$src_rsync"
else
is_macos=0
readonly rsync="$(command -v rsync || true)"
[[ -n "$rsync" ]] || fail \
"Failed to locate host rsync." \
"rules_xcodeproj's bundled rsync is only supported on macOS project generation."
fi

"$rsync" \
--archive \
--perms \
--chmod=u+w,F-x \
--delete \
"$src_xcschemes" "$dest_xcschemes/"

# Resolve the copy command (can't use `cp -c` if the files are on different
# filesystems, or on Linux)
if [[ $is_macos -eq 1 &&
Expand Down
Loading