Skip to content

Fix running under nix#3169

Merged
aaronsky merged 1 commit into
MobileNativeFoundation:mainfrom
timothyklim:nix-fixes
May 8, 2026
Merged

Fix running under nix#3169
aaronsky merged 1 commit into
MobileNativeFoundation:mainfrom
timothyklim:nix-fixes

Conversation

@timothyklim
Copy link
Copy Markdown
Contributor

Also escaping whitespaces in output_groups

@timothyklim timothyklim requested a review from a team as a code owner April 18, 2025 13:49
@adincebic
Copy link
Copy Markdown
Contributor

@timothyklim you'll have to sign off your commit.

@timothyklim
Copy link
Copy Markdown
Contributor Author

@timothyklim you'll have to sign off your commit.

done

Comment thread xcodeproj/internal/templates/bazel_build.sh Outdated
@brentleyjones brentleyjones changed the title Running under nix Fix running under nix Apr 18, 2025
@timothyklim
Copy link
Copy Markdown
Contributor Author

For output_groups_flag I want rollback because I only use use_default_shell_env right now.

@timothyklim
Copy link
Copy Markdown
Contributor Author

done

@aaronsky
Copy link
Copy Markdown
Contributor

aaronsky commented May 6, 2026

@timothyklim can you rebase and fix the failing checks so we can merge this?

@timothyklim
Copy link
Copy Markdown
Contributor Author

rebase

Rebased.

@aaronsky
Copy link
Copy Markdown
Contributor

aaronsky commented May 7, 2026

@timothyklim once you get DCO passing we can approve workflows to run

@timothyklim
Copy link
Copy Markdown
Contributor Author

DCO passed

Signed-off-by: Timothy Klim <git@timothyklim.com>
@aaronsky aaronsky enabled auto-merge (squash) May 8, 2026 06:57
@aaronsky aaronsky merged commit bf72498 into MobileNativeFoundation:main May 8, 2026
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants