Jest test runner#64
Open
FutureAstroMiner wants to merge 3 commits intoMirroar:masterfrom
Open
Conversation
Owner
|
Thank you! I was thinking of moving from ava to jest because that's what the typescript starter uses, so this will be a nice base for doing that. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I noticed that some of the tests in the utilities test file will no longer work (due to some refactoring that was done last year.
I have done some work to use the jest typescript starter that includes converting over some of your existing tests.
Up to you if you want them or not.
I had to add hivemind to global as I couldn't get the tests to work otherwise. There might be a way but I am not sure.
I had to disable some of the tests as I couldn't see what they were testing. This could be improved upon.
This might be better committed to a branch and worked on there but up to you.