Conversation
Agent-Logs-Url: https://github.com/Minibrams/fastapi-decorators/sessions/67e76ca3-1b6c-4ff2-924f-20789f9a2341 Co-authored-by: Minibrams <8108085+Minibrams@users.noreply.github.com>
Agent-Logs-Url: https://github.com/Minibrams/fastapi-decorators/sessions/67e76ca3-1b6c-4ff2-924f-20789f9a2341 Co-authored-by: Minibrams <8108085+Minibrams@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix @depends modifying function return type when it's None
Preserve explicit Mar 29, 2026
-> None return annotations in @depends-wrapped endpoint signatures
|
I'll get put out of my job cuz of copilot 🫡 ps: i dont have a job |
Minibrams
approved these changes
Mar 30, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@dependswas rebuilding wrapped function signatures with a type-hint-resolved return annotation, which converted explicit-> NoneintoNoneType. In FastAPI, this could cause incorrect response model inference and trigger204 No Contentassertion errors unless users added manual workarounds (response_model=Noneor removing return typing).Signature reconstruction fix
depends()to keep the original function’s return annotation verbatim when creating__signature__.Noneexactly as authored and avoids changing FastAPI route semantics for no-content endpoints.Regression coverage
async def ... -> Nonewithstatus_code=204and a@dependsdecorator.204response without requiring workaround configuration.✨ Let Copilot coding agent set things up for you — coding agent works faster and does higher quality work when set up for your repo.