Fix exploding values#18
Open
roeezis wants to merge 4 commits into
Open
Conversation
Fix non-converging local smoothing filter (with eventual NaN rnorm)
This reverts commit 7264621.
Fix non convergence of the local smoothing filter iterations, eventually resulting in NaN rnorm
Codecov Report
@@ Coverage Diff @@
## master #18 +/- ##
============================================
- Coverage 40.85% 40.85% -0.01%
- Complexity 7221 7222 +1
============================================
Files 264 264
Lines 63167 63167
Branches 10299 10299
============================================
- Hits 25809 25806 -3
- Misses 35659 35663 +4
+ Partials 1699 1698 -1
Continue to review full report at Codecov.
|
add a newline at the end of the .gitignore file
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix non convergence of the local smoothing filter iterations, as sdot(d,q) would be Infinity for large numbers, eventually resulting in NaN rnorm.
the fix changes float to 64bit double precision for scalars, sdot and saxpy calculations.