Finish removal of native support for abandoned economy plugins.#863
Finish removal of native support for abandoned economy plugins.#863cerealcable merged 2 commits intoMilkBowl:masterfrom
Conversation
|
Took me a few tries to get this building properly, locally it complains about the pom formatting but it is building now as best it can. CI only failed to deploy after building correctly. |
|
Agree on that - EssentialsX currently has code to load Vault properly. It will be good to let go of the old economy code. P.S. Maybe the same can be done with the old permission plugins code too... |
|
@mirolm thanks for taking a look, this PR goes hand in hand with one I have open at the VaultAPI repo. Might be possible to do something similar to permission and chat plugins but I'm more concerned with Economy's future. |
|
This PR has failed checks (we've sinced fixed the build configs, so rebase) and has conflicts. Any chance @LlmDl you could address this and then we'll be able to get to final reviews/merging? |
|
You should remove these plugins from the README as well |
|
I will do that as well. |
- All economy plugins removed as libs. - None of them are actively developed, many abandoned in 2011. - Removal of Register hook. - Register was last updated by the Towny team, many years ago, it is no longer used by any modern server. - Remove VaultEco class, unused after removal of Register compatibilty.
|
First PR to build in a decade! /s |
cerealcable
left a comment
cerealcable
left a comment
There was a problem hiding this comment.
Looks good, time to move on!
|
Just back from holiday and I see this is merged, very nice! I'll start work on your Vault-API review tomorrow. |
4 participants
This Pull Request complements MilkBowl/VaultAPI#112 in finishing the removal of economy plugins from Vault. This process was begun years ago when many other such economy plugins were removed after being determined abandoned.
The modern standard is that an economy plugin will implement Vault in their own code.
Here are the last-update dates on the plugins removed:
