Bug. Error code value 0xFF used as array index.#7
Open
urgent-canadian wants to merge 1 commit intoMicrochipTech:masterfrom
Open
Bug. Error code value 0xFF used as array index.#7urgent-canadian wants to merge 1 commit intoMicrochipTech:masterfrom
urgent-canadian wants to merge 1 commit intoMicrochipTech:masterfrom
Conversation
…e error code value 0xff was used as array index.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When a packet is received and all Rx buffers are full, the variable RxBank is left with its pre-initialized value of 0xFF.
The RxBank variable was then used as an array index into a buffer array of BANK_SIZE elements.
The error code value of uint8_t 0xFF used as an array index causes packet data to be written far outside the memory allocated
for the buffer table of BANK_SIZE elements (4 elements).
255 > 4
:-)