Skip to content

feat: add confirmation dialog before sendTransfer and before signing a PSBT from the keyring handler#591

Open
Battambang wants to merge 10 commits intomainfrom
feat/signpsbt-sendtransfer-confirmation-dialog
Open

feat: add confirmation dialog before sendTransfer and before signing a PSBT from the keyring handler#591
Battambang wants to merge 10 commits intomainfrom
feat/signpsbt-sendtransfer-confirmation-dialog

Conversation

@Battambang
Copy link
Copy Markdown
Contributor

@Battambang Battambang commented Mar 13, 2026

Explanation

This PR contributes to supporting the Bitcoin dApp connectivity.
It's adding the a confirmation dialog to the user before a dApp calling for a sendTransfer() and before signing a PSBT from the keyring handler entrypoint.

It is part from the initial PR #564 feat: enable account address resolution to support dApps connectivity to split the work into 3 smaller PRs:
#589 refactor: move validation structs and add account field
#590 feat: add resolveAccountAddress method to KeyringHandler for dApp connectivity routing
#591 feat: add confirmation dialog before sendTransfer and before signing a PSBT from the keyring handler

Confirmation dialog

References

Checklist

  • I've updated the test suite for new or updated code as appropriate
  • I've updated documentation (JSDoc, Markdown, etc.) for new or updated code as appropriate
  • I've communicated my changes to consumers by updating changelogs for packages I've changed
  • I've introduced breaking changes in this PR and have prepared draft pull requests for clients and consumer packages to resolve them

Note

Medium Risk
Adds user-confirmation gating to keyring-driven SignPsbt and SendTransfer flows and introduces account-address resolution for MetaMask routing, which can block or reroute signing/transfer requests if validation/UX assumptions are wrong. Also changes request validation shape and sendTransfer semantics (single-recipient, frozen UTXO handling), impacting dApp integrations.

Overview
Adds explicit user confirmation before dApp-initiated signing and transfers. KeyringRequestHandler now requires a confirmation via ConfirmationRepository before executing SignPsbt, and AccountUseCases.sendTransfer builds a PSBT (respecting frozen UTXOs and fee rate) and shows a confirmation UI before broadcasting.

Introduces MetaMask routing support for Bitcoin requests. KeyringHandler implements keyring_resolveAccountAddress, validating incoming Bitcoin JSON-RPC requests and mapping the requested account address + scope to a CAIP-10 address (or null on failure).

Updates request schemas + UI. Bitcoin keyring request params now include account: { address } across capabilities; integration/unit tests are updated accordingly, and a new SignPsbtConfirmationView plus new i18n strings display PSBT details (outputs, fee, options, raw PSBT) and request origin in confirmations.

Reviewed by Cursor Bugbot for commit 63953ac. Bugbot is set up for automated code reviews on this repo. Configure here.

@Battambang Battambang requested a review from a team as a code owner March 13, 2026 23:50
Copy link
Copy Markdown

@cursor cursor bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

@Battambang
Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/bitcoin-wallet-snap": "1.10.0-preview-89127a1"
}

@Battambang
Copy link
Copy Markdown
Contributor Author

@metamaskbot publish-preview

@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Apr 7, 2026

Preview builds have been published. See these instructions for more information about preview builds.

Expand for full list of packages and versions.
{
  "@metamask-previews/bitcoin-wallet-snap": "1.10.1-preview-63953ac"
}

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants