feat: add confirmation dialog before sendTransfer and before signing a PSBT from the keyring handler#591
Open
Battambang wants to merge 10 commits intomainfrom
Open
feat: add confirmation dialog before sendTransfer and before signing a PSBT from the keyring handler#591Battambang wants to merge 10 commits intomainfrom
Battambang wants to merge 10 commits intomainfrom
Conversation
…ddress } to all request types
…quest for integration tests
…nectivity routing
…ready guarantees the method is valid
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
8944681 to
89127a1
Compare
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
Contributor
Author
|
@metamaskbot publish-preview |
Contributor
|
Preview builds have been published. See these instructions for more information about preview builds. Expand for full list of packages and versions. |
0xEdouardEth
approved these changes
Apr 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Explanation
This PR contributes to supporting the Bitcoin dApp connectivity.
It's adding the a confirmation dialog to the user before a dApp calling for a sendTransfer() and before signing a PSBT from the keyring handler entrypoint.
It is part from the initial PR #564 feat: enable account address resolution to support dApps connectivity to split the work into 3 smaller PRs:
#589 refactor: move validation structs and add account field
#590 feat: add resolveAccountAddress method to KeyringHandler for dApp connectivity routing
#591 feat: add confirmation dialog before sendTransfer and before signing a PSBT from the keyring handler
References
Checklist
Note
Medium Risk
Adds user-confirmation gating to keyring-driven
SignPsbtandSendTransferflows and introduces account-address resolution for MetaMask routing, which can block or reroute signing/transfer requests if validation/UX assumptions are wrong. Also changes request validation shape andsendTransfersemantics (single-recipient, frozen UTXO handling), impacting dApp integrations.Overview
Adds explicit user confirmation before dApp-initiated signing and transfers.
KeyringRequestHandlernow requires a confirmation viaConfirmationRepositorybefore executingSignPsbt, andAccountUseCases.sendTransferbuilds a PSBT (respecting frozen UTXOs and fee rate) and shows a confirmation UI before broadcasting.Introduces MetaMask routing support for Bitcoin requests.
KeyringHandlerimplementskeyring_resolveAccountAddress, validating incoming Bitcoin JSON-RPC requests and mapping the requested accountaddress+scopeto a CAIP-10 address (ornullon failure).Updates request schemas + UI. Bitcoin keyring request params now include
account: { address }across capabilities; integration/unit tests are updated accordingly, and a newSignPsbtConfirmationViewplus new i18n strings display PSBT details (outputs, fee, options, raw PSBT) and request origin in confirmations.Reviewed by Cursor Bugbot for commit 63953ac. Bugbot is set up for automated code reviews on this repo. Configure here.