Open
Conversation
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What?
VedaAdapter.sol— a new adapter contract for delegation-based deposits and withdrawals on Veda BoringVaultIVedaTeller.sol— minimal interface for Veda's TellerWithMultiAssetSupportVedaLending.t.sol— comprehensive test suite (fork tests, happy paths, input validation, events, batch operations, edge cases, 3-level delegation chain)Why?
How?
DelegationMetaSwapAdapterteller.bulkDeposit()to mint shares directly to the root delegatorteller.withdraw()to burn shares and send underlying assets to the root delegatordepositByDelegationBatch/withdrawByDelegationBatchwithdrawEmergency(owner-only) for recovering tokens accidentally sent to the contractNote
INK_RPC_URL=https://ink.drpc.orgto your.envNote
Medium Risk
Adds a new on-chain adapter that redeems delegations to move ERC20s/vault shares and manage approvals before calling into an external Teller/Vault, so bugs could directly impact user funds despite extensive fork-based tests.
Overview
Adds a new
VedaAdaptercontract that redeems delegation chains to execute Veda BoringVault deposits (token transfer →bulkDepositminting shares to the root delegator) and withdrawals (share transfer →withdrawsending assets to the root delegator), including batch variants and an owner-onlywithdrawEmergencytoken recovery path.Introduces
IVedaTelleras a minimal interface for the required Teller entrypoints and addsVedaLending.t.solfork tests covering happy paths, input validation/reverts, event emission, batching, allowance behavior, and multi-level delegation-chain resolution.Written by Cursor Bugbot for commit 686b3b5. This will update automatically on new commits. Configure here.