for #174... squash ln -sf into one event#212
Open
petersilva wants to merge 3 commits intodevelopmentfrom
Open
Conversation
Contributor
Author
|
any feedback on this? still worth doing? or did you do other stuff on the python side, so we should just close this? |
Member
|
I'm not sure quite yet, CMOI hasn't tested the new python code yet. If it doesn't fix the problem, this might be worth revisiting. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I dunno if this works. It's kind of a sample of what I meant in #174 (comment)
It passes test_shim_post, but on my system none of the other shim tests pass... so I'm not sure if it's any good. I mean it didn't pass with dev branch either. so unclear, it's probably not worse, but I can't tell.
My try it out, and see if it helps? would not want to merge without more testing.