Enable lfric_xios_file_type to take configuration from an associated XIOS field group#352
Open
Ed Hone (EdHone) wants to merge 5 commits intoMetOffice:mainfrom
Open
Enable lfric_xios_file_type to take configuration from an associated XIOS field group#352Ed Hone (EdHone) wants to merge 5 commits intoMetOffice:mainfrom
Ed Hone (EdHone) wants to merge 5 commits intoMetOffice:mainfrom
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer:
Code Reviewer: mo-marqh
This brings together the use of XIOS field groups within the
lfric_xios_file_type. This will enable applications to configure the behaviour of fields within a file, without needing large-scale code changes within the model code itself.By default an XIOS field group with the ID
{FILE_ID}_fieldswill be created for each file defined with alfric_xios_file_typeobject. This default ID can be overwritten by passing thefield_group_idargument to thelfric_xios_file_typeconstructor. If this field group is already defined within an XML configuration it wont be overwritten so any fields contained with that field group can be configured by the model at run time.I also fixed the iodef files in the lfric-xios integration tests to make them runnable with XIOS 3
closes #351
Code Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - lfric_core-351-file-field_group/run2
Suite Information
Task Information
✅ succeeded tasks - 390
I've also run these changes against lfric_apps
Test Suite Results - lfric_apps - lfric_apps-test_field_groups/run3
Suite Information
Task Information
✅ succeeded tasks - 1185
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review