Skip to content

Fix log field#347

Open
Mike Hobson (mike-hobson) wants to merge 2 commits intoMetOffice:mainfrom
mike-hobson:fix_log_field
Open

Fix log field#347
Mike Hobson (mike-hobson) wants to merge 2 commits intoMetOffice:mainfrom
mike-hobson:fix_log_field

Conversation

@mike-hobson
Copy link
Copy Markdown
Contributor

@mike-hobson Mike Hobson (mike-hobson) commented Apr 24, 2026

PR Summary

Sci/Tech Reviewer: Matthew Hambley (@MatthewHambley)
Code Reviewer: Ed Hone (@EdHone)

The log_field() functionality in utilities/log_field_mod.f90 is not working so needs fixing. It is only provided for debugging purposes, so is not routinely called from any application and currently has no unit test. This has allowed the code to become stale and stop working.

Obviously, the code needs fixing, but also a unit test should be added to prevent the code from becoming stale again in the future.

This function can produce a lot of output, so it would also be useful to allow log_field() to only output a section of the field data

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_core - fix_log_field/run5

Suite Information

Item Value
Suite Name fix_log_field/run5
Suite User mike.hobson
Workflow Start 2026-04-24T08:30:13
Groups Run all
Dependency Reference Main Like
lfric_core mike-hobson/lfric_core@fix_log_field False
SimSys_Scripts MetOffice/SimSys_Scripts@cab3315 True

Task Information

✅ succeeded tasks - 388

Security Considerations

  • I have reviewed my changes for potential security issues
  • Sensitive data is properly handled (if applicable)
  • Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a straight forward change which not only fixes a bug but adds some additional flexibility to the call.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Reinstate the log_field functionality

3 participants