Fix log field#347
Open
Mike Hobson (mike-hobson) wants to merge 2 commits intoMetOffice:mainfrom
Open
Conversation
Matthew Hambley (MatthewHambley)
approved these changes
Apr 29, 2026
Collaborator
Matthew Hambley (MatthewHambley)
left a comment
There was a problem hiding this comment.
This is a straight forward change which not only fixes a bug but adds some additional flexibility to the call.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: Matthew Hambley (@MatthewHambley)
Code Reviewer: Ed Hone (@EdHone)
The
log_field()functionality inutilities/log_field_mod.f90is not working so needs fixing. It is only provided for debugging purposes, so is not routinely called from any application and currently has no unit test. This has allowed the code to become stale and stop working.Obviously, the code needs fixing, but also a unit test should be added to prevent the code from becoming stale again in the future.
This function can produce a lot of output, so it would also be useful to allow
log_field()to only output a section of the field dataCode Quality Checklist
Testing
trac.log
Test Suite Results - lfric_core - fix_log_field/run5
Suite Information
Task Information
✅ succeeded tasks - 388
Security Considerations
Performance Impact
AI Assistance and Attribution
Documentation
PSyclone Approval
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review