-
Notifications
You must be signed in to change notification settings - Fork 58
Deprecate copy field halo kernel #341
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Alistair Pirrie (mo-alistairp)
wants to merge
12
commits into
MetOffice:main
Choose a base branch
from
mo-alistairp:deprecate_copy_field_halo_kernel
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
12 commits
Select commit
Hold shift + click to select a range
3e9ce93
Replace invoke_X_innerproduct_
mo-alistairp 6a58660
Revert "Replace invoke_X_innerproduct_" (#2)
mo-alistairp 66b80d1
Add new PSyKAl to copy into clean halos
mo-alistairp 8b26bbb
temporarily add my own clean halo depth check
mo-alistairp ab6b9b1
Add depth to parameter descriptions
mo-alistairp fe1271b
Merge branch 'main' into deprecate_copy_field_halo_kernel
mo-alistairp d18f22b
Change over to use get_clean_depth
mo-alistairp 4f3497b
Correct the get_clean_depth() call
mo-alistairp 0b03870
Delete copy_field_halo_kernel_mod and its test
mo-alistairp c3eb183
Add a set_clean
mo-alistairp dde8d0f
Flip the order of the input/output
mo-alistairp a9cc186
Merge branch 'main' into deprecate_copy_field_halo_kernel
mo-alistairp File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
72 changes: 0 additions & 72 deletions
72
components/science/source/kernel/algebra/copy_field_halo_kernel_mod.F90
This file was deleted.
Oops, something went wrong.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
36 changes: 0 additions & 36 deletions
36
components/science/unit-test/kernel/algebra/copy_field_halo_kernel_mod_test.pf
This file was deleted.
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there not be a
call field_out_proxy%set_clean(clean_halo_depth)included after this - otherwise the copying to a clean depth in the halo is entirely pointless, as it will just get halo exchanged anyway
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I think you're right.