Add support for psyclone 3.3, nvfortran and amdflang

[Sergi Siso (sergisiso)]

PR Summary

Sci/Tech Reviewer:
Code Reviewer: Andrew Coughtrie (@andrewcoughtrie)

Add support for amdflang and provide workarounds for the nvfortran limitations discussed with Hacka Fett (@christophermaynard)

Also add support for the upcoming psyclone release (3.3) and update broken psyclone links and oudated names. These are not breaking changes, the code remains compabible with the current psyclone release 3.2.2.

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Core rose-stem suite
• If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[Thomas Bendall (tommbendall)]

Looks fine from a code owner perspective. I'm not sure how it was previously compiling without r_def being imported!

[Sergi Siso (sergisiso)]

Thomas Bendall (@tommbendall) r_def only appears in an invoke's kernel argument, and the whole expression is moved to the psy_layer where there is an unqualified constants_mod import. This happens to make the generated code valid, but we are introducing stricter symbol checking in PSyclone, which will report these undefined symbols. There are a few similar cases in lfric_apps that I will also propose fixes for.

[Thomas Bendall (tommbendall)]

Thomas Bendall (Thomas Bendall (@tommbendall)) r_def only appears in an invoke's kernel argument, and the whole expression is moved to the psy_layer where there is an unqualified constants_mod import. This happens to make the generated code valid, but we are introducing stricter symbol checking in PSyclone, which will report these undefined symbols. There are a few similar cases in lfric_apps that I will also propose fixes for.

That makes sense, thanks for explaining!

[Matthew Hambley (MatthewHambley)]

Build system code owner saying "this looks okay."

[Matthew Hambley (MatthewHambley)]

Except it says "AMD Clang" at the top.

[Sergi Siso (sergisiso)]

Updated now

[Matthew Hambley (MatthewHambley)]

Does the AMD compiler use the GNU C++ runtime?

[Sergi Siso (sergisiso)]

No, it uses the Clang runtime, the message was a leftover from copy-pasting the GNU file.