Made io_value_type data attribute private

[allynt]

PR Summary

Sci/Tech Reviewer:
Code Reviewer: Mike Hobson (@mike-hobson)

Made io_value_type "data" attribute private. And added getter and setter to access that attribute.

• linked Used getter and setter for io_value_type%data attribute lfric_apps#444

Code Quality Checklist

• I have performed a self-review of my own code
• My code follows the project's style guidelines
• Comments have been included that aid understanding and enhance the readability of the code
• My changes generate no new warnings
• All automated checks in the CI pipeline have completed successfully

Testing

• I have tested this change locally, using the LFRic Core rose-stem suite
• If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
• If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
• I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
• Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

trac.log

Test Suite Results - lfric_core - io_value_type_core/run3

Suite Information

Item	Value
Suite Name	io_value_type_core/run3
Suite User	allyn.treshansky
Workflow Start	2026-04-20T11:51:36
Groups Run	developer

Dependency	Reference	Main Like
lfric_core	allynt/lfric_core@io_value_type	False
SimSys_Scripts	MetOffice/SimSys_Scripts@4387949	True

Task Information

✅ succeeded tasks - 390

Security Considerations

• I have reviewed my changes for potential security issues
• Sensitive data is properly handled (if applicable)
• Authentication and authorisation are properly implemented (if applicable)

Performance Impact

• Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

• Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

• Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

• If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

• I understand this area of code and the changes being added
• The proposed changes correspond to the pull request description
• Documentation is sufficient (do documentation papers need updating)
• Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

• All dependencies have been resolved
• Related Issues have been properly linked and addressed
• CLA compliance has been confirmed
• Code quality standards have been met
• Tests are adequate and have passed
• Documentation is complete and accurate
• Security considerations have been addressed
• Performance impact is acceptable

[Mike Hobson (mike-hobson)]

Hi Allyn,

I know you've put quite a bit of time into getting this working, so I feel a bit mean questioning it, now. But is there a specific reason for making this change? I've chatted to Andy (who was involved in it's original creation) and he said that they made a deliberate decision to make the data payload public. It makes accessing the data really easy and doesn't expose much more that you get with providing a setter and getter.

If there's a specific reason for making it private (that might put Andy's mind at rest) then that's fine, but if not, we probably shouldn't be changing the original design.