Skip to content

292 fab pfunit#323

Open
Joerg Henrichs (hiker) wants to merge 70 commits intoMetOffice:mainfrom
hiker:292_fab_pfunit
Open

292 fab pfunit#323
Joerg Henrichs (hiker) wants to merge 70 commits intoMetOffice:mainfrom
hiker:292_fab_pfunit

Conversation

@hiker
Copy link
Copy Markdown
Contributor

@hiker Joerg Henrichs (hiker) commented Apr 1, 2026

PR Summary

Sci/Tech Reviewer:
Code Reviewer: Matthew Hambley (@MatthewHambley)

As discussed, this PR adds a mixin class that enables building of PFUnit-tests. It adds support to the skeleton app.

Code Quality Checklist

  • I have performed a self-review of my own code
  • My code follows the project's style guidelines
  • Comments have been included that aid understanding and enhance the readability of the code
  • My changes generate no new warnings
  • All automated checks in the CI pipeline have completed successfully

Testing

All N/A - this change does not integrate with cylc yet. Local builds have been successful.

  • I have tested this change locally, using the LFRic Core rose-stem suite
  • If required (e.g. API changes) I have also run the LFRic Apps test suite using this branch
  • If any tests fail (rose-stem or CI) the reason is understood and acceptable (e.g. kgo changes)
  • I have added tests to cover new functionality as appropriate (e.g. system tests, unit tests, etc.)
  • Any new tests have been assigned an appropriate amount of compute resource and have been allocated to an appropriate testing group (i.e. the developer tests are for jobs which use a small amount of compute resource and complete in a matter of minutes)

Building skeleton with (and without) testing is now possible.

trac.log

N/A

Security Considerations

  • I have reviewed my changes for potential security issues
  • [N/A] Sensitive data is properly handled (if applicable)
  • [N/A] Authentication and authorisation are properly implemented (if applicable)

Performance Impact

  • [N/A] Performance of the code has been considered and, if applicable, suitable performance measurements have been conducted

AI Assistance and Attribution

  • [N/A] Some of the content of this change has been produced with the assistance of Generative AI tool name (e.g., Met Office Github Copilot Enterprise, Github Copilot Personal, ChatGPT GPT-4, etc) and I have followed the Simulation Systems AI policy (including attribution labels)

Documentation

  • Where appropriate I have updated documentation related to this change and confirmed that it builds correctly

PSyclone Approval

  • [N/A] If you have edited any PSyclone-related code (e.g. PSyKAl-lite, Kernel interface, optimisation scripts, LFRic data structure code) then please contact the TCD Team

Sci/Tech Review

  • I understand this area of code and the changes being added
  • The proposed changes correspond to the pull request description
  • Documentation is sufficient (do documentation papers need updating)
  • Sufficient testing has been completed

(Please alert the code reviewer via a tag when you have approved the SR)

Code Review

  • All dependencies have been resolved
  • Related Issues have been properly linked and addressed
  • CLA compliance has been confirmed
  • Code quality standards have been met
  • Tests are adequate and have passed
  • Documentation is complete and accurate
  • Security considerations have been addressed
  • Performance impact is acceptable

Joerg Henrichs (hiker) and others added 30 commits January 23, 2026 17:40
@github-actions github-actions Bot added the cla-signed The CLA has been signed as part of this PR - added by GA label Apr 1, 2026
@github-actions github-actions Bot removed the cla-signed The CLA has been signed as part of this PR - added by GA label May 6, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support pfunit testing with Fab

4 participants