Post-processing: Support for the 'threads' output file format#245
Merged
Ed Hone (EdHone) merged 5 commits intoMetOffice:mainfrom Apr 14, 2026
Merged
Post-processing: Support for the 'threads' output file format#245Ed Hone (EdHone) merged 5 commits intoMetOffice:mainfrom
Ed Hone (EdHone) merged 5 commits intoMetOffice:mainfrom
Conversation
Ed Hone (EdHone)
requested review from
Andrew Coughtrie (andrewcoughtrie) and
Oakley Brunt (oakleybrunt)
Ed Hone (EdHone)
force-pushed
the
py-vernier-threadsfile
branch
from
de80e53 to
e79b1da
Compare
Oakley Brunt (oakleybrunt)
requested changes
Apr 13, 2026
Contributor
Oakley Brunt (oakleybrunt)
left a comment
Oakley Brunt (oakleybrunt)
left a comment
There was a problem hiding this comment.
Thanks Ed, this looks like a good change. Just a couple things to address regarding documentation and adding a test.
Comment on lines
+118
to
+122
| def _parse_drhook_data(self, file_contents) -> VernierData: | ||
| """ | ||
| Parses the contents of a Vernier output file in the 'drhook' format | ||
| into a VernierData object. | ||
| """ |
Contributor
There was a problem hiding this comment.
Please add parameter and returns to docstring.
Comment on lines
+54
to
+58
| def _parse_threadsfile_data(self, file_contents) -> VernierData: | ||
| """ | ||
| Parses the contents of a Vernier output file in the 'threads' format | ||
| into a VernierData object. | ||
| """ |
Contributor
There was a problem hiding this comment.
Please add parameter and returns to docstring.
Comment on lines
39
to
45
| def _get_file_format(self, file_header) -> VernierFileFormat: | ||
| """ | ||
| Loads Vernier data from a single file, and returns it as a VernierData | ||
| object. | ||
| Determines file format based on file contents - looks for the presence | ||
| of characteristic string fragments in a provided section of the file | ||
| contents. | ||
|
|
||
| """ |
Contributor
There was a problem hiding this comment.
Please add parameter and returns to docstring.
Collaborator
Author
|
Thanks Oakley Brunt (@oakleybrunt) - I believe I have addressed your comments in my |
Oakley Brunt (oakleybrunt)
approved these changes
Apr 14, 2026
Contributor
Oakley Brunt (oakleybrunt)
left a comment
Oakley Brunt (oakleybrunt)
left a comment
There was a problem hiding this comment.
Thanks Ed, happy to approve now
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR introduces parsing functionality for the alternative 'threads' vernier output format. New test data has been introduced for the new format and the data has been reorganised to reflect the differences between the data. New tests have been added for the new read functionality.
There has also been a slightly change to the CLI script to correct the path setting to enable running of the unit-tests without installing the package first.
Linked issues
Closes #243
Type of change
How has this been tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: