Open
Conversation
…es which git / VS Code are marking as in conflict. Annoyingly, this seems to have introduced a bug as well.
…esolving clashes. But looking at it, I really can't fathom out 'how'
…n't edited this file...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Summary
Sci/Tech Reviewer: @t00sa
Code Reviewer: @ericaneininger
The Abstract class and 2 real classes setup was a bit clunky.
I thought I could merge the two into one real class, but after trying that it transpires I needed a subclass to overwrite the behaviour of the
checkmethod for external runners.Whilst I'm still struggling at times with the Linters VS Code deploys on the desktop, this change seems to have "re-discovered" a bunch of lines that are too long, in a file I'd not touched. There was a messed up "merge of main" which I presume caused this, but I'm just baffled.
Code Quality Checklist
Testing
It has been run on itself, in 'Python' mode, with no errors
In it's default 'Fortran' Mode :
It has been run on a 'um' branch with no failures.
It has been run on a um branch with VAF (Value Added Failures), where it identified the requisite failures.
It has been run on um/main , where it had a whale of a time identifying 874 files (out of 2406) with errors in them.
pytest has been run on the repository, no errors reported.
Security Considerations
AI Assistance and Attribution
Sci/Tech Review
(Please alert the code reviewer via a tag when you have approved the SR)
Code Review