Conversation
Fedr
changed the title
Grantim
reviewed
Apr 6, 2026
source/MRMesh/MRMeshFillHole.h
Outdated
Comment on lines
+193
to
+196
| /// returns true if executeHoleFillPlan() with the same topology and plan | ||
| /// does not introduce any edge with the same end-vertices as any existed edge in the mesh; | ||
| /// note: this function can be used for checking filling plans generated independently before executing them one by one | ||
| [[nodiscard]] MRMESH_API bool doesFillingMultipleEdgeFree( const MeshTopology & topology, const HoleFillPlan & plan ); |
source/MRMesh/MRMeshFillHole.h
Outdated
|
|
||
| /// returns true if executeHoleFillPlan() with the same topology and plan | ||
| /// does not introduce any edge with the same end-vertices as any existed edge in the mesh; | ||
| /// note: this function can be used for checking filling plans generated independently before executing them one by one |
Contributor
There was a problem hiding this comment.
could it really be used before executing several filling plans at once, or should be called before executing each one?
Fedr
changed the title
Grantim
approved these changes
Apr 6, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
New function
isFillingMultipleEdgeFreethat can be used for checking checking a fill plan that was generated before filling other holes. If the function returnsfalsejust callfillHoleinstead of executing bad plan.Tests added.