Skip to content

fix meshing problem: #4

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
lavenklau wants to merge 1 commit into
base: master
Choose a base branch
from
Open

fix meshing problem: #4

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/lib/isosurface_inflator/CGALClippedVolumeMesher.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,7 +156,8 @@ mesh(const SignedDistanceRegion<3> &sdf,
// Mesh generation
// std::cout << "Making mesh..." << std::endl;
BENCHMARK_START_TIMER("make_mesh_3");
C3t3 c3t3 = CGAL::make_mesh_3<C3t3>(domain, criteria);
C3t3 c3t3 = CGAL::make_mesh_3<C3t3>(domain, criteria, CGAL::parameters::features(domain),
CGAL::parameters::odt(), CGAL::parameters::perturb(0, 20), CGAL::parameters::exude(0, 20));
// CGAL sometimes returns an empty mesh for some patterns due to
// insufficient initialization:
// https://github.com/CGAL/cgal/issues/2416
Expand Down
2 changes: 1 addition & 1 deletion src/lib/isosurface_inflator/ConvexHullTriangulation.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,7 @@ void convexHullFromTriangulation(const PointCollection &points,
for (size_t i = 0; 3 * i < indexBuffer.size(); ++i) {
hullElements[i].resize(3);
for (size_t lv = 0; lv < 3; ++lv) {
hullElements[i][lv] = newVertexId[indexBuffer[i * lv + lv]];
hullElements[i][lv] = newVertexId[indexBuffer[i * 3 + lv]];
}
}
}
Expand Down
3 changes: 2 additions & 1 deletion src/lib/isosurface_inflator/PostProcess.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,7 +125,8 @@ void postProcess(vector<MeshIO::IOVertex> &vertices,
<< "WARNING: smartSnap3D failed--probably nonsmooth geometry at cell interface. Resorting to dumbSnap3D."
<< std::endl;
std::cerr << "(" << e.what() << ")" << std::endl;
dumbSnap3D(vertices, meshCell, opts.facetDistance);
// dumbSnap3D(vertices, meshCell, opts.facetDistance);
dumbSnap3D(vertices, meshCell, 2 * opts.domainErrorBound);
}
BBox<Point3D> snappedBB(vertices);
if (N == 2) {
Expand Down