fix: deduplicate OG images by URL to prevent unique constraint violation#743
Open
Manishcs076 wants to merge 1 commit intoMerit-Systems:mainfrom
Open
fix: deduplicate OG images by URL to prevent unique constraint violation#743Manishcs076 wants to merge 1 commit intoMerit-Systems:mainfrom
Manishcs076 wants to merge 1 commit intoMerit-Systems:mainfrom
Conversation
Prevents unique constraint violation when scraped pages return duplicate OG image entries with the same URL. Uses a Map to keep only the last occurrence of each URL before the parallel upsert, matching the composite unique key (originId, url). Fixes Merit-Systems#287
Contributor
|
@Manishcs076 is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #287 — resource registration fails when scraped pages return duplicate OG image URLs.
Problem
When a page returns multiple OG image entries with the same URL, the concurrent
Promise.allupserts race against each other on the(originId, url)composite unique constraint, causing a unique constraint violation.Fix
Deduplicate OG images by URL using a Map before passing them to
Promise.all. This ensures each URL is upserted exactly once per origin, eliminating the race condition.Changes
apps/scan/src/services/db/resources/origin.ts: +5 lines — deduplicateogImagesarray by URL before upsertingMinimal, surgical fix — no other behavior changed.