fix(scan): prevent OgImage unique constraint conflict on registration (#287)#730
Open
xidik12 wants to merge 1 commit intoMerit-Systems:mainfrom
Open
fix(scan): prevent OgImage unique constraint conflict on registration (#287)#730xidik12 wants to merge 1 commit intoMerit-Systems:mainfrom
xidik12 wants to merge 1 commit intoMerit-Systems:mainfrom
Conversation
…stration When registering a new resource whose origin shares an OG image URL with another origin, the upsert could fail with a unique constraint violation on the url field. This adds a catch-and-retry approach that gracefully handles the P2002 error by creating or updating the OG image entry for the current origin. Closes Merit-Systems#287
Contributor
|
@xidik12 is attempting to deploy a commit to the Merit Systems Team on Vercel. A member of the Team first needs to authorize it. |
![vercel[bot]](https://avatars.githubusercontent.com/in/8329?s=60&v=4){kind=small}
| error instanceof Error && | ||
| 'code' in error && | ||
| (error as { code: string }).code === 'P2002'; | ||
| if (isUniqueViolation) { |
Contributor
There was a problem hiding this comment.
OgImage upsert silently fails to update metadata when unique constraint violation occurs for an image already belonging to the same origin
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Root Cause
The OgImage table had a global unique constraint on the url field (OgImage_url_key). When two origins share the same OG image URL (e.g., due to CDN or redirects), the upsert on originId_url would not find a match for the new origin, and the create branch would fail on the global url constraint.
Fix
Added error handling around the ogImage upsert that catches P2002 (unique constraint violation) and retries with a safe create-or-update pattern for the current origin.
Closes #287