Skip to content

fix: display non-string query parameters in resource registry#715

Closed
craigbidenbot[bot] wants to merge 1 commit intomainfrom
craig/fix-non-string-query-params
Closed

fix: display non-string query parameters in resource registry#715
craigbidenbot[bot] wants to merge 1 commit intomainfrom
craig/fix-non-string-query-params

Conversation

@craigbidenbot
Copy link
Copy Markdown
Contributor

@craigbidenbot craigbidenbot bot commented Mar 13, 2026

Summary

Number and boolean query params (like page and include_gt_community_data) were silently dropped from the Resource Registry display. Only string-typed schema values were handled.

Changes

  • schema.ts: Handle typeof raw === 'number' and typeof raw === 'boolean' in expandFields, inferring type as integer/number or boolean respectively, with defaults pre-filled
  • form/index.tsx: Add queryFields to targetUrl dependency array so typed query values serialize correctly into the URL

Test Plan

  • View a resource with mixed query param types (e.g. CoinGecko trending pools with page=1, duration=5m, include_gt_community_data=true, include=base_token)
  • Verify all 4 params now appear in the form
  • Verify integer/boolean params serialize correctly when executing the request

Closes #623

Number and boolean query parameters were silently dropped by
expandFields (only strings and objects were handled). Also fixes
targetUrl to properly serialize typed query values.

Closes #623
@vercel
Copy link
Copy Markdown
Contributor

vercel bot commented Mar 13, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
x402scan Ready Ready Preview, Comment Mar 13, 2026 10:46pm

Copy link
Copy Markdown
Contributor

@vercel vercel bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Suggestion:

isValidFieldValue function doesn't validate type-specific constraints, allowing invalid numbers in required fields to pass validation but get silently dropped during serialization

Fix on Vercel

@fmhall
Copy link
Copy Markdown
Member

fmhall commented Apr 15, 2026

We've since removed the ResourceExecutor and its display code entirely in favor of a simpler "Copy Prompt" flow that directs users to test endpoints via agentcash.dev. The query parameter rendering this fixed no longer exists. Closing as obsolete.

@fmhall fmhall closed this Apr 15, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Resource Registry not displaying non-string query parameters

2 participants