fix: display non-string query parameters in resource registry#715
Closed
craigbidenbot[bot] wants to merge 1 commit intomainfrom
Closed
fix: display non-string query parameters in resource registry#715craigbidenbot[bot] wants to merge 1 commit intomainfrom
craigbidenbot[bot] wants to merge 1 commit intomainfrom
Conversation
Number and boolean query parameters were silently dropped by expandFields (only strings and objects were handled). Also fixes targetUrl to properly serialize typed query values. Closes #623
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
2 tasks
Member
|
We've since removed the ResourceExecutor and its display code entirely in favor of a simpler "Copy Prompt" flow that directs users to test endpoints via agentcash.dev. The query parameter rendering this fixed no longer exists. Closing as obsolete. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Number and boolean query params (like
pageandinclude_gt_community_data) were silently dropped from the Resource Registry display. Only string-typed schema values were handled.Changes
schema.ts: Handletypeof raw === 'number'andtypeof raw === 'boolean'inexpandFields, inferring type asinteger/numberorbooleanrespectively, with defaults pre-filledform/index.tsx: AddqueryFieldstotargetUrldependency array so typed query values serialize correctly into the URLTest Plan
page=1,duration=5m,include_gt_community_data=true,include=base_token)Closes #623