fix: normalize URLs in deprecateStaleResources to prevent false deprecation#696
Open
craigbidenbot[bot] wants to merge 1 commit intomainfrom
Open
fix: normalize URLs in deprecateStaleResources to prevent false deprecation#696craigbidenbot[bot] wants to merge 1 commit intomainfrom
craigbidenbot[bot] wants to merge 1 commit intomainfrom
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…form registerResource strips query params (urlObj.search = '') before storing, but deprecateStaleResources compared raw discovery URLs against the DB. This mismatch caused all existing resources to be falsely deprecated when re-registering via discovery, making the server listing disappear. Fixes #693
craigbidenbot
bot
force-pushed
the
craig/fix-deprecate-url-normalization
branch
from
3037ed5 to
fcce970
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Server listings disappear after re-registering via discovery because
deprecateStaleResourcescompares raw discovery URLs against DB-stored URLs, which have had query params stripped byregisterResource. The mismatch causes all existing resources to be falsely deprecated.Changes
normalizeResourceUrlhelper that strips query params (matchingregisterResource's canonical form)activeResourceUrlsbefore thenotIncomparison indeprecateStaleResourcesRoot Cause
registerResourcestores URLs withurlObj.search = ''(query params stripped), butdeprecateStaleResourcescompared against raw discovery URLs. When discovery URLs differed from the stored canonical form, thenotInclause failed to match existing resources → they were all deprecated → origin disappeared from listings.Test Plan
Fixes #693