Batch resource probes in register-origin to avoid transaction timeouts#683
Open
Batch resource probes in register-origin to avoid transaction timeouts#683
Conversation
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
register-originendpoint fires all resource probes concurrently via a singlePromise.allSettled. For origins with many resources (e.g. stablecrypto.dev with 105 endpoints), this opens 105+ concurrent DB transactions that saturate the connection pool. Under repeated load, transactions time out waiting for connections —Unable to start a transaction in the given time.Promise.allSettledwith a batched for-loop processing 10 resources at a time. Extracted the probe logic into a standaloneprobeAndRegisterfunction for cleaner typing and readability.Testing
Tested against production (old code) — 5 sequential runs on stablecrypto.dev:
Tested against preview branch (batched code) — 10 sequential runs on stablecrypto.dev: