Example of staged commits following the polyclean pattern (Feature/pokemon card)#10
Draft
va1ha11a wants to merge 17 commits into
Draft
Example of staged commits following the polyclean pattern (Feature/pokemon card)#10va1ha11a wants to merge 17 commits into
va1ha11a wants to merge 17 commits into
Conversation
va1ha11a
changed the title
va1ha11a
force-pushed
the
feature/pokemon_card
branch
from
9e9c348 to
5d3aeda
Compare
- Add azure-functions dependency to workspace and project - Refactor function_app.py to import from main.py (no duplication) - Use func.AsgiMiddleware to wrap FastAPI app for Azure Functions
- Add empty collection and multiple cards list tests - Add invalid condition, negative HP, empty name validation tests - Add missing required field, HP max, set_number, notes length tests - Add remove non-existent card test Total tests increased from 42 to 54.
- Change db_path to Path | str type in SQLitePokemonAdapter - Rename Azure Functions app variable to avoid conflict
Centralize the card condition values in the contract component to eliminate duplication across flow, entity, and base. The enum is now the single source of truth for valid conditions.
va1ha11a
force-pushed
the
feature/pokemon_card
branch
from
5d3aeda to
86dc864
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Example branch showing how changes can be staged in a progressive way.
In this PR each commit is an atomic change that should allow for an easy review while keeping the code base stable.
These commits could easily be PRs each and if they were larger bricks that would be preferred.
Additionally, if _libs are used they can be separated and committed/PR'd prior to the brick(s) that consume them.