feat: include created_at timestamp in search results#846
Merged
bensig merged 2 commits intoMemPalace:developfrom Apr 15, 2026
Merged
feat: include created_at timestamp in search results#846bensig merged 2 commits intoMemPalace:developfrom
bensig merged 2 commits intoMemPalace:developfrom
Conversation
sha2fiddy
requested review from
bensig,
igorls and
milla-jovovich
as code owners
igorls
added
area/search
…e#465) Surface the existing filed_at metadata as created_at in search result objects returned by search_memories(). Enables temporal reasoning over search hits without additional queries.
sha2fiddy
force-pushed
the
feature/465/created-at-in-search
branch
from
fb3142c to
64ab16b
Compare
kbtale
suggested changes
Apr 14, 2026
| "wing": meta.get("wing", "unknown"), | ||
| "room": meta.get("room", "unknown"), | ||
| "source_file": Path(source).name if source else "?", | ||
| "created_at": meta.get("filed_at"), |
There was a problem hiding this comment.
Wouldn't an explicit fallback value be useful here? all the other fields that pull from external data seem to have a fallback.
bensig
approved these changes
Apr 15, 2026
Collaborator
bensig
left a comment
bensig
left a comment
There was a problem hiding this comment.
Code reviewed — no issues found. CLAUDE.md compliance verified.
igorls
added a commit
that referenced
this pull request
Apr 16, 2026
Advisor caught: initial boundary (962776c..develop) skipped PRs that landed on develop after v3.3.0 tag but before the sync-back merge. Adds entries for #871 MEMPAL_VERBOSE, #811 research() local-only default, #866 init .gitignore, #864 MCP stdout redirect, #863 precompact hook, #865 searcher empty results, #831 cold-start palace, #862 init help, #815 Slack provenance, #840 save hook auto-mine. Also drops the awkward caveat on #846 created_at — it's post-v3.3.0.
shafdev
pushed a commit
to shafdev/mempalace
that referenced
this pull request
Apr 17, 2026
Advisor caught: initial boundary (962776c..develop) skipped PRs that landed on develop after v3.3.0 tag but before the sync-back merge. Adds entries for MemPalace#871 MEMPAL_VERBOSE, MemPalace#811 research() local-only default, MemPalace#866 init .gitignore, MemPalace#864 MCP stdout redirect, MemPalace#863 precompact hook, MemPalace#865 searcher empty results, MemPalace#831 cold-start palace, MemPalace#862 init help, MemPalace#815 Slack provenance, MemPalace#840 save hook auto-mine. Also drops the awkward caveat on MemPalace#846 created_at — it's post-v3.3.0.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
filed_atmetadata ascreated_atin search result objects returned bysearch_memories()Closes #465
Changes
mempalace/searcher.py: Addedcreated_atfield to search result entry dict, sourced frommeta.get("filed_at")tests/test_searcher.py: Addedcreated_atpresence check totest_result_fields, plus newtest_created_at_contains_filed_atverifying the value matches the storedfiled_atmetadataTest plan
test_result_fields— verifiescreated_atkey exists in search resultstest_created_at_contains_filed_at— verifies value matches the seededfiled_atmetadata (2026-01-01T00:00:00)ruff check .,ruff format --check .with CI-pinned ruff >=0.4.0,<0.5)