Merged
Conversation
This is a rewrite of d3dhook using minhook which was being used in other places in caster already, this is api compatible with there being a caveat of it returning different strings but those shouldn't affect it where it's being used. The rewrite was done so d3d9 hooking would work on linux and then allowing for some wine specific workarounds to be removed along with enabling the frame limiter in linux. The only problem with this is that it seems to crash on alt-enter on debug builds since dearimgui seems not to like it, unsure if this is linux only or a problem that was happening before.
Owner
|
looks great, ty |
Open
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I rewrote d3dhook with minhook which was already being used elsewhere, I mainly wrote this so I could get the new frame limiter working on linux but that doesn't use the d3dhook anymore and I originally wrote the PR at Rhekar#18 but the PR also does enable the frame limiter on linux so it isn't that redundant and I also remove some workarounds caused by wine not being able to use the original hooks.
Not sure if this is the ideal way to do things but it seems to work...
Notes: