Skip to content

Backport 3.6: ssl: accept TLS 1.2 rsa_pss_rsae signature algorithms#10674

Merged
ronald-cron-arm merged 3 commits intoMbed-TLS:mbedtls-3.6from
Maokaman1:fix/tls12-rsa-pss-sigalgs-3.6
Apr 20, 2026
Merged

Backport 3.6: ssl: accept TLS 1.2 rsa_pss_rsae signature algorithms#10674
ronald-cron-arm merged 3 commits intoMbed-TLS:mbedtls-3.6from
Maokaman1:fix/tls12-rsa-pss-sigalgs-3.6

Conversation

@Maokaman1
Copy link
Copy Markdown
Contributor

@Maokaman1 Maokaman1 commented Apr 4, 2026

Description

Backport of #10672

PR checklist

Signed-off-by: Viktor Sokolovskiy <maokaman@gmail.com>
(cherry picked from commit c064ba0)
@gilles-peskine-arm gilles-peskine-arm added needs-review Every commit must be reviewed by at least two team members, needs-ci Needs to pass CI tests needs-reviewer This PR needs someone to pick it up for review priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most) labels Apr 4, 2026
@gilles-peskine-arm gilles-peskine-arm self-requested a review April 4, 2026 20:43
Narrow TLS 1.2 RSA-PSS handling to the client ServerKeyExchange parse path and add OpenSSL and GnuTLS interoperability tests.

Signed-off-by: Viktor Sokolovskiy <maokaman@gmail.com>
@Maokaman1 Maokaman1 changed the title Backport 3.6: ssl: accept TLS 1.2 rsa_pss_rsae signature schemes Backport 3.6: ssl: accept TLS 1.2 rsa_pss_rsae signature algorithms Apr 17, 2026
Copy link
Copy Markdown
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM as a backport of #10672

Not sure why one comment is shorter here, but it doesn't matter, we wouldn't add full PSS support in this long-time support branch anyway.

@gilles-peskine-arm gilles-peskine-arm removed the needs-reviewer This PR needs someone to pick it up for review label Apr 17, 2026
Signed-off-by: Viktor Sokolovskiy <maokaman@gmail.com>
@JustAnotherEndUser
Copy link
Copy Markdown

Copy link
Copy Markdown
Contributor

@gilles-peskine-arm gilles-peskine-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gilles-peskine-arm
Copy link
Copy Markdown
Contributor

@JustAnotherEndUser It does seem to be the same issue, yes: a server offering only TLS 1.2 but wanting to use RSA-PSS as the signature algorithm. Try this patch if you want to be sure.

@JustAnotherEndUser
Copy link
Copy Markdown

@gilles-peskine-arm - Thank you. I will look for the new package release and test when it is available.

@ronald-cron-arm ronald-cron-arm removed the needs-ci Needs to pass CI tests label Apr 20, 2026
Copy link
Copy Markdown
Contributor

@ronald-cron-arm ronald-cron-arm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from In Development to Has Approval in Roadmap pull requests (new board) Apr 20, 2026
@ronald-cron-arm ronald-cron-arm added approved Design and code approved - may be waiting for CI or backports and removed needs-review Every commit must be reviewed by at least two team members, labels Apr 20, 2026
@ronald-cron-arm ronald-cron-arm added this pull request to the merge queue Apr 20, 2026
Merged via the queue into Mbed-TLS:mbedtls-3.6 with commit 7da1c56 Apr 20, 2026
4 checks passed
@github-project-automation github-project-automation Bot moved this from Has Approval to Done in Roadmap pull requests (new board) Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved Design and code approved - may be waiting for CI or backports priority-high High priority - will be reviewed soon size-xs Estimated task size: extra small (a few hours at most)

Development

Successfully merging this pull request may close these issues.

4 participants