Add fix for -DENABLE_PROGRAMS=OFF build error#10654
Open
bjwtaylor wants to merge 2 commits intoMbed-TLS:developmentfrom
Open
Add fix for -DENABLE_PROGRAMS=OFF build error#10654bjwtaylor wants to merge 2 commits intoMbed-TLS:developmentfrom
bjwtaylor wants to merge 2 commits intoMbed-TLS:developmentfrom
Conversation
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
7 tasks
bjwtaylor
added
the
needs-backports
bjwtaylor
added
needs-review
gilles-peskine-arm
previously approved these changes
Apr 10, 2026
Contributor
gilles-peskine-arm
left a comment
gilles-peskine-arm
left a comment
There was a problem hiding this comment.
LGTM except for the missing changelog entry.
This is minor, so we don't need a test.
| add_custom_target(handshake-generated.sh | ||
| DEPENDS ${CMAKE_CURRENT_SOURCE_DIR}/opt-testcases/handshake-generated.sh) | ||
| set_target_properties(handshake-generated.sh PROPERTIES EXCLUDE_FROM_ALL NO) | ||
| if(ENABLE_PROGRAMS) |
Contributor
There was a problem hiding this comment.
Since this fixes a reported bug, please add a changelog entry with Fixes #10587.
gilles-peskine-arm
added
needs-work
size-xs
Signed-off-by: Ben Taylor <ben.taylor@linaro.org>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Add fix for -DENABLE_PROGRAMS=OFF build error, resolves #10587
PR checklist